fix: ensure WebContents before checking draggable region#41154
Merged
codebytere merged 1 commit intomainfrom Jan 30, 2024
Merged
fix: ensure WebContents before checking draggable region#41154codebytere merged 1 commit intomainfrom
WebContents before checking draggable region#41154codebytere merged 1 commit intomainfrom
Conversation
deepak1556
approved these changes
Jan 29, 2024
Member
deepak1556
left a comment
There was a problem hiding this comment.
Something to consider, Crash keys are useful in production crash analysis, we can confirm if it was use-after-free before making the fix.
SCOPED_CRASH_KEY_BOOL("WebContentsView_NCHT", "api_web_contents", api_web_contents_ != nullptr)
Member
Author
|
@deepak1556 in local testing I was able to confirm that |
Member
|
Ah not required in that case, I was not sure if the crash was repro'd hence the earlier comment. |
|
Release Notes Persisted
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41142
Fixes an issue with potential crashes while closing or interacting with a WebContentsView after its associated WebContents has been cleaned up. We first need to ensure that
api_web_contents_is not nullptr, as is done several other places in the same file.Checklist
npm testpassesRelease Notes
Notes: Fixed a potential crash while closing or interacting with a WebContentsView after its associated WebContents has been cleaned up.