Skip to content

test: draggable region allows moving window#41127

Merged
codebytere merged 5 commits intoelectron:mainfrom
samuelmaddock:test/draggable-region
Jan 31, 2024
Merged

test: draggable region allows moving window#41127
codebytere merged 5 commits intoelectron:mainfrom
samuelmaddock:test/draggable-region

Conversation

@samuelmaddock
Copy link
Copy Markdown
Member

@samuelmaddock samuelmaddock commented Jan 25, 2024 •
edited
Loading

Description of Change

Added a test to move a window around using draggable regions. This is in response to a recent regression following a Chromium upgrade which was not caught.

Nutjs is used to automate mouse dragging. This seems like a worthy dependency to try out since I know we've had issues with robotjs in the past.

Here's the test in action:

Screen.Recording.2024-01-26.at.12.31.55.PM.mov

As an aside, I found that using Mac Stage Manager causes windows with position x=0 to be offset from the left side of the screen (as seen in the video).

Checklist

Release Notes

Notes: none

@samuelmaddock
Copy link
Copy Markdown
Member Author

samuelmaddock commented Jan 26, 2024

Previous tests for Windows passed, I'm not sure why they're failing now.

@samuelmaddock samuelmaddock marked this pull request as ready for review January 26, 2024 19:21
codebytere
codebytere approved these changes Jan 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the added dependency. I assume we'll want to add more dragging tests, but i'm 👍🏻 on starting with this for now!

@codebytere
Copy link
Copy Markdown
Member

codebytere commented Jan 30, 2024

Windows error:

FAILED: gen/services/network/public/mojom/websocket_mojom__type_mappings 
C:/projects/src/depot_tools/bootstrap-2@3_11_6_chromium_30_bin/python3/bin/python3.exe ../../build/util/action_remote.py ../../buildtools/reclient/rewrapper --cfg=../../buildtools/reclient_cfgs/python/rewrapper_windows.cfg --exec_root=C:/projects/src/ --input_list_paths=gen/services/network/public/mojom/websocket_mojom__type_mappings__remote_inputs.rsp --output_list_paths=gen/services/network/public/mojom/websocket_mojom__type_mappings__remote_outputs.rsp python3 ../../mojo/public/tools/bindings/generate_type_mappings.py --output gen/services/network/public/mojom/websocket_mojom__type_mappings --dependency gen/services/network/public/mojom/mojom_ip_address__type_mappings --dependency gen/services/network/public/mojom/mojom_network_param__type_mappings --dependency gen/mojo/public/mojom/base/base__type_mappings --dependency gen/url/mojom/url_mojom_gurl__type_mappings --dependency gen/url/mojom/url_mojom_origin__type_mappings --cpp-typemap-config gen/services/network/public/mojom/websocket_mojom.typemap_config
'python3' is not recognized as an internal or external command,
operable program or batch file.
[639 processes, 17852/49666 @ 50.9/s : 350.928s] CXX obj/base/base/thread_id_name_manager.obj
[638 processes, 17853/49666 @ 50.9/s : 350.932s] CXX obj/base/base/file_enumerator.obj

feels pretty unrelated to me - maybe try rebasing @samuelmaddock?

@codebytere codebytere merged commit 85bebfb into electron:main Jan 31, 2024
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Jan 31, 2024

No Release Notes

@samuelmaddock samuelmaddock deleted the test/draggable-region branch January 31, 2024 15:15
This was referenced Jan 31, 2024
Merged
Open
@jkleinsc jkleinsc mentioned this pull request Mar 7, 2024
Merged
4 tasks
@ckerr ckerr mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@clavin clavin Awaiting requested review from clavin

Assignees

No one assigned

Labels

no-backport semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuelmaddock @codebytere