feat: add webPreferences.frozenIntrinsics
#38571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89889a8 to
20339aa
Compare
00944ef to
45e733a
Compare
b37e361 to
093997d
Compare
ee2f793 to
1944ce9
Compare
webPreferences.frozenIntrinsics
codebytere
reviewed
Aug 7, 2023
Member
codebytere
left a comment
There was a problem hiding this comment.
Your PR body doesn't describe the goal of adding this option - why is it something developers would want to enable? What benefits does it confer and where could someone read more about that? Given it's experimental in Node.js, should we wait until it's stable?
patches/node/fix_make_sharedarraybuffer_optional_in_freeze_intrinsics_js.patch
Outdated
Show resolved
Hide resolved
1944ce9 to
28e03dd
Compare
5f36197 to
b4714ca
Compare
cfdcc9d to
94b9feb
Compare
94b9feb to
6ba8835
Compare
zcbenz
reviewed
Feb 8, 2024
Contributor
There was a problem hiding this comment.
The API name implies all intrinsics in the WebContents will be frozen, but it seems that this only affects the intrinsics in Node context?
If this means to be Node context only, I think the API name should make that explicit, or we can probably add a nodeIntegrationArgs: [] options instead.
| every iframe, you can use `process.isMainFrame` to determine if you are | ||
| in the main frame or not. | ||
| * `frozenIntrinsics` boolean (optional) - Experimental option for passing | ||
| [`--frozen-intrinsics`](https://nodejs.org/api/cli.html#--frozen-intrinsics) to Node.js. |
Contributor
There was a problem hiding this comment.
The document should clarity whether this requires nodeIntegration: true to work, and how it works with contextIsolate: true.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
@miniak is there still interest in adding this feature? |
Member
|
I'm closing this for now, but feel free to reopen after rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allows enabling the experimental https://nodejs.org/api/cli.html#--frozen-intrinsics
Checklist
npm testpassesRelease Notes
Notes: Added
webPreferences.frozenIntrinsics, which passes--frozen-intrinsicsto node.