Conversation
VerteDinde
approved these changes
Mar 1, 2023
VerteDinde
reviewed
Mar 1, 2023
MarshallOfSound
approved these changes
Mar 2, 2023
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
Terrifying, I love it. One non-blocking nit on the dcheck
|
Release Notes Persisted
|
This was referenced Mar 2, 2023
Contributor
|
I have automatically backported this PR to "23-x-y", please check out #37473 |
Contributor
|
I have automatically backported this PR to "24-x-y", please check out #37474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This makes draggable regions work on MAS builds again, after they broke in
#35603.
The mas_disable_custom_window_frame.patch patch prevents the Chrome custom frame from being used on MAS, but the new draggable regions impl on macOS requires it, so we need to find another way of getting this behavior without tripping the MAS guards.
Fixes #37414.
Checklist
npm testpassesRelease Notes
Notes: Fixed draggable regions not working in Mac App Store builds.