Skip to content

chore: improve contents.takeHeapSnapshot error messages#37434

Merged
jkleinsc merged 2 commits intomainfrom
improve-takeheapsnapshot-errors
Mar 1, 2023
Merged

chore: improve contents.takeHeapSnapshot error messages#37434
jkleinsc merged 2 commits intomainfrom
improve-takeheapsnapshot-errors

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Feb 28, 2023

Description of Change

Closes #37424.

Adds more descriptive error messages to contents.takeHeapSnapshot so that users better understand why it may have failed.

Checklist

Release Notes

Notes: Improved error messages for contents.takeHeapSnapshot.

@codebytere codebytere added semver/patch backwards-compatible bug fixes 22-x-y target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 28, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 28, 2023
@codebytere codebytere force-pushed the improve-takeheapsnapshot-errors branch 2 times, most recently from 03a1711 to fb65494 Compare February 28, 2023 14:44
@codebytere codebytere force-pushed the improve-takeheapsnapshot-errors branch from fb65494 to 97fb422 Compare March 1, 2023 08:57
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 1, 2023
@codebytere codebytere added target/22-x-y PR should also be added to the "22-x-y" branch. and removed 22-x-y labels Mar 1, 2023
@jkleinsc jkleinsc merged commit 9b20b3a into main Mar 1, 2023
@jkleinsc jkleinsc deleted the improve-takeheapsnapshot-errors branch March 1, 2023 15:50
@release-clerk
Copy link

release-clerk bot commented Mar 1, 2023

Release Notes Persisted

Improved error messages for contents.takeHeapSnapshot.

This was referenced Mar 1, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 1, 2023

I have automatically backported this PR to "22-x-y", please check out #37459

@trop
Copy link
Contributor

trop bot commented Mar 1, 2023

I have automatically backported this PR to "23-x-y", please check out #37460

@trop trop bot added in-flight/22-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Mar 1, 2023
@trop trop bot mentioned this pull request Mar 1, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Mar 1, 2023

I have automatically backported this PR to "24-x-y", please check out #37461

@trop trop bot added in-flight/24-x-y merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/23-x-y labels Mar 1, 2023
@commit-lint commit-lint bot mentioned this pull request May 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: takeHeapSnapshot is always throwing an error

2 participants

@codebytere @jkleinsc