fix: Notification with reply obscuring first action on macOS#37381
Merged
codebytere merged 1 commit intomainfrom Mar 1, 2023
Merged
fix: Notification with reply obscuring first action on macOS#37381codebytere merged 1 commit intomainfrom
Notification with reply obscuring first action on macOS#37381codebytere merged 1 commit intomainfrom
Conversation
Notification with reply obscuring first action on macOS
codebytere
commented
Feb 22, 2023
| [notification_ setSoundName:base::SysUTF16ToNSString(options.sound)]; | ||
| } | ||
|
|
||
| [notification_ setHasActionButton:false]; |
Member
Author
There was a problem hiding this comment.
the default value is false - we don't need to call this explicitly.
844e85a to
386feb4
Compare
zcbenz
approved these changes
Mar 1, 2023
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "22-x-y", please check out #37447 |
This was referenced Mar 1, 2023
Contributor
|
I have automatically backported this PR to "23-x-y", please check out #37448 |
Contributor
|
I have automatically backported this PR to "24-x-y", please check out #37449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37376.
Fixes an issue where passing both
hasReplyandactionsto a main process Notification on macOS resulted in the first action being obscured and unavailable. This was happening because we calledsetHasActionButtonfor the first available button, followed bysetHasReplyButton. Per documentation, ifhasReplyButtonandhasActionButtonare both YES, the reply button is shown. This meant that the first action would be lost.We fix this by setting the reply first, and if there are actions, setting them all as additional actions.
Before
After
Tested with https://gist.github.com/bb92e0d0cf83439e176b3d970e533104
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where passing both
hasReplyandactionsto a main process Notification on macOS resulted in the first action being obscured and unavailable.