fix: ensure that chromium binds to wayland interface versions it supports#32652
Merged
zcbenz merged 1 commit intoelectron:13-x-yfrom Jan 31, 2022
Molytho:13-x-y
Merged
fix: ensure that chromium binds to wayland interface versions it supports#32652zcbenz merged 1 commit intoelectron:13-x-yfrom Molytho:13-x-y
zcbenz merged 1 commit intoelectron:13-x-yfrom
Molytho:13-x-y
Conversation
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
This patch is required to fix Ozone/Wayland on recent compositors (e.g. wlroots 15). Chromium tries to bind to interface versions it does not support. This wasn't a problem until wl_output version 4 got released because chromium supported every version up to this. Fix #32487. Upstream chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1279574
codebytere
approved these changes
Jan 31, 2022
zcbenz
approved these changes
Jan 31, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium tries to bind to the newest version of some wayland interfaces. This causes issues when it doesn't actually support the version.
This patch ensures that only supported versions are bound to.
Fixes #32487
Backport of #32603
Notes: none.