Skip to content

fix: crash creating private key with unsupported algorithm #31137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 3 commits into from
Sep 29, 2021
Merged

fix: crash creating private key with unsupported algorithm #31137

jkleinsc merged 3 commits into from
Sep 29, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 27, 2021

Backport of #31087

See that PR for details.

Notes: Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

@trop trop bot requested a review from a team as a code owner September 27, 2021 13:02
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 27, 2021
@trop trop bot requested a review from codebytere September 27, 2021 13:02
@trop trop bot mentioned this pull request Sep 27, 2021
Merged
4 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 27, 2021
@codebytere codebytere force-pushed the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch from f4fdb79 to 9c294cf Compare September 27, 2021 20:56
@codebytere codebytere force-pushed the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch from 9c294cf to 859872e Compare September 27, 2021 20:57
@jkleinsc jkleinsc merged commit 2cbfd19 into 15-x-y Sep 29, 2021
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch September 29, 2021 15:56
@release-clerk
Copy link

release-clerk bot commented Sep 29, 2021

Release Notes Persisted

Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkleinsc @codebytere