fix: BrowserWindow backgroundColor#30778
Merged
zcbenz merged 2 commits intoelectron:mainfrom Sep 6, 2021
Merged
Conversation
1b87f50 to
84e32ef
Compare
nornagon
suggested changes
Sep 1, 2021
819dae6 to
cfb39c6
Compare
Member
Author
|
@nornagon I found a better approach for this. To make a WebContents transparent, we only need to set the background color to It also doesn't make sense to enforce transparency of the WebContents based on the options passed to BrowserWindow. The user should be able to change the background color to not be transparent at any time. With these changes, WebContents transparency via |
cfb39c6 to
78a93c1
Compare
nornagon
approved these changes
Sep 2, 2021
codebytere
approved these changes
Sep 3, 2021
zcbenz
approved these changes
Sep 6, 2021
|
No Release Notes |
3 tasks
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
fixes #30759
Port of #30777 which targets v14+15. I manually ported this to latest because of the changes to WebPreferences in #30193
The code below would fail to convert a hex string to an
SkColorwhich resulted in the RVHW's background color always being set to transparent.electron/shell/browser/web_contents_preferences.cc
Line 227 in dd7aeda
cc @codebytere @nornagon
Checklist
npm testpassesRelease Notes
Notes: none