fix: nativeTheme.themeSource = 'dark' on windows#26238
Merged
Merged
Conversation
Manually backports #25373.
6 tasks
Member
|
The releases WG approved this PR for backport to 11-x-y at the Oct 28, 2020 meeting |
codebytere
approved these changes
Oct 29, 2020
zcbenz
approved these changes
Nov 2, 2020
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
fix:
nativeTheme.themeSource = 'dark'on windows iff build flag is enabled. (Disabled by default)Manually backports #25373.
CC @deepak1556 @electron/wg-releases
Checklist
npm testpassesRelease Notes
Notes: none