fix: pdf preview download button not working#24946
Merged
codebytere merged 1 commit intomasterfrom Aug 17, 2020
Merged
Conversation
zcbenz
approved these changes
Aug 17, 2020
|
Release Notes Persisted
|
This was referenced Aug 17, 2020
Contributor
|
I have automatically backported this PR to "10-x-y", please check out #24995 |
Contributor
|
I have automatically backported this PR to "9-x-y", please check out #24996 |
|
Curious if anyone else is experiencing this, loading local packaged pdf, save works perfectly when served but when packaged it shows the save prompt but there is no pdf file created. |
|
Hi, is there any solution to this saving pdf issue? Thank you in advance |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #22178.
Before: Nothing.
After:
Unfortunately this can't be hooked up to
will-downloadinfrastructure in its current form - it runs through fairly separate logic and adding the ability to intercept and prevent default a la the existing event implementation would require some patching that at this juncture i don't think is in our best interest.cc @nornagon
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the Save button did not function in PDF previews.