Skip to content

feat: enable native extensions support#21814

Merged
nornagon merged 19 commits intomasterfrom
enable-electron-extensions
Feb 3, 2020
Merged

feat: enable native extensions support#21814
nornagon merged 19 commits intomasterfrom
enable-electron-extensions

Conversation

@nornagon
Copy link
Copy Markdown
Contributor

@nornagon nornagon commented Jan 17, 2020

Description of Change

This enables the enable_electron_extensions flag by default.

Ref #19447

Checklist

Release Notes

Notes: Switched to a native-backed implementation of Chrome Extensions.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 17, 2020
@nornagon
Copy link
Copy Markdown
Contributor Author

nornagon commented Jan 17, 2020

This is marked [WIP] because there are several outstanding PRs that I'd like to merge before this one: #21812, #21811, #21809, and #21804. But I do believe this feature is ready to be switched on!

@nornagon nornagon mentioned this pull request Jan 17, 2020
Closed
11 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 18, 2020
@nornagon nornagon mentioned this pull request Jan 21, 2020
Closed
3 tasks
@nornagon nornagon force-pushed the enable-electron-extensions branch from 9055cfb to 99059ce Compare January 21, 2020 17:46
@nornagon nornagon removed the wip ⚒ label Jan 21, 2020
@nornagon nornagon force-pushed the enable-electron-extensions branch from c5b0af1 to 4cd8a9e Compare January 24, 2020 03:46
@nornagon nornagon force-pushed the enable-electron-extensions branch from 4cd8a9e to 2279e2d Compare January 24, 2020 03:53
zcbenz
zcbenz reviewed Jan 28, 2020
View reviewed changes
@nornagon nornagon mentioned this pull request Jan 29, 2020
Merged
6 tasks
zcbenz
zcbenz approved these changes Jan 30, 2020
View reviewed changes
shell/browser/api/atom_api_session.cc Outdated
const std::string& error_msg) {
if (extension) {
if (!error_msg.empty()) {
LOG(INFO) << "ELW 1";
Copy link
Copy Markdown
Contributor

@zcbenz zcbenz Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Copy Markdown
Contributor Author

@nornagon nornagon Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, good catch!

@nornagon
Copy link
Copy Markdown
Contributor Author

nornagon commented Feb 3, 2020

CI failures are unrelated to this PR; merging.

@nornagon nornagon merged commit a061c87 into master Feb 3, 2020
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Feb 3, 2020

Release Notes Persisted

Switched to a native-backed implementation of Chrome Extensions.

@nornagon nornagon deleted the enable-electron-extensions branch February 4, 2020 00:59
@nornagon nornagon mentioned this pull request Feb 10, 2020
Closed
@erickzhao erickzhao mentioned this pull request May 7, 2020
Merged
@nornagon nornagon mentioned this pull request May 20, 2020
Closed
3 tasks
@rafeca rafeca mentioned this pull request Jul 17, 2020
Merged
@erickzhao erickzhao mentioned this pull request Nov 3, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nornagon @zcbenz