feat: [extensions] implement a couple of tabs APIs#21779
Merged
Conversation
11 tasks
samuelmaddock
approved these changes
Jan 15, 2020
| IDR_IME_SERVICE_MOJOM_JS); | ||
| source_map->RegisterSource("chromeos.ime.service", | ||
| IDR_IME_SERVICE_BINDINGS_JS); | ||
| #endif // defined(OS_CHROMEOS) |
Member
There was a problem hiding this comment.
Could remove this section since it's related to Chrome OS
jkleinsc
approved these changes
Jan 15, 2020
Member
jkleinsc
left a comment
There was a problem hiding this comment.
LGTM assuming lint issues are addressed.
Contributor
Author
|
win32 failure unrelated |
|
No Release Notes |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This (sort of) implements chrome.tabs.executeScript. It only works with non-negative tab IDs (i.e. the default of "active tab" will throw a validation error), and it makes no special effort to prevent extensions from accessing "tabs" they haven't requested permission to (though there does seem to be at least some protections in place in the code I've added, mostly copied from Chrome. I'm not sure if those are watertight though.)
Also implements chrome.tabs.sendMessage, which the Ember DevTools extension depends on.
This is enough to get the React and Ember DevTools extensions working when
enable_electron_extensions = true.Ref #19447
Checklist
npm testpassesRelease Notes
Notes: none