feat: [extensions] background pages#21591
Merged
Conversation
11 tasks
Member
samuelmaddock
left a comment
There was a problem hiding this comment.
Left a few comments. It looks surprisingly straightforward to add background page support after reading through the code, nice!
| : api_client_(new extensions::ExtensionsAPIClient), | ||
| // : api_client_(new extensions::AtomExtensionsAPIClient), | ||
| : api_client_(new extensions::ElectronExtensionsAPIClient), | ||
| process_manager_delegate_(new extensions::ElectronProcessManagerDelegate), |
Member
There was a problem hiding this comment.
Random thought while reading this code. It might be cool if the extensions system could be configured at startup from the JS runtime. That way only projects interested in using extensions could opt-in to initializing all of these subsystems.
nornagon
commented
Jan 13, 2020
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds support for lazy background pages when building with ENABLE_ELECTRON_EXTENSIONS. One step closer to a functional React DevTools!
NB. no release notes because this feature is still behind the ENABLE_ELECTRON_EXTENSIONS flag, which is not enabled in Electron release builds.
Ref #19447
Checklist
npm testpassesRelease Notes
Notes: none