Skip to content

fix: only override default window.close() in windows opened with nativeWindowOpen: false #19813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miniak wants to merge 1 commit into from
Closed

fix: only override default window.close() in windows opened with nativeWindowOpen: false #19813

miniak wants to merge 1 commit into from

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Aug 18, 2019 •
edited
Loading

Description of Change

Fixes #19194

Checklist

Release Notes

Notes: window.close() does no longer close the window when called in BrowserView.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 18, 2019
@miniak miniak mentioned this pull request Aug 18, 2019
Closed
3 tasks
@miniak miniak self-assigned this Aug 18, 2019
@miniak miniak added the wip ⚒ label Aug 18, 2019
@PalmerAL
Copy link
Contributor

PalmerAL commented Aug 19, 2019

@miniak With this change, will it be possible to listen for a close event somewhere in order to remove the view from the window? There's a close event documented for webview, but I don't see anything similar for webContents or BrowserView.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 19, 2019
@miniak miniak closed this Sep 11, 2019
@miniak miniak reopened this Oct 26, 2019
@miniak miniak force-pushed the miniak/fix-window-close branch from 0fbd478 to 4d9d042 Compare October 26, 2019 11:21
@miniak miniak closed this Nov 4, 2019
@miniak miniak deleted the miniak/fix-window-close branch November 4, 2019 23:41
@sentialx
Copy link
Contributor

sentialx commented Nov 22, 2019

@miniak What happened with this PR?

@miniak
Copy link
Contributor Author

miniak commented Dec 7, 2019

@sentialx I am going to revive it

@miniak miniak restored the miniak/fix-window-close branch December 12, 2019 21:42
@miniak miniak reopened this Dec 12, 2019
@miniak miniak force-pushed the miniak/fix-window-close branch from 4d9d042 to a41681e Compare December 12, 2019 21:45
@miniak miniak mentioned this pull request Dec 16, 2019
Merged
5 tasks
@miniak miniak closed this Oct 9, 2020
@zcbenz zcbenz deleted the miniak/fix-window-close branch February 15, 2021 06:26
@pushkin- pushkin- mentioned this pull request Mar 18, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miniak miniak

Labels

wip ⚒

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use window.close in Browserview-webcontents(web page) will close the app!!!!!!!

4 participants

@miniak @PalmerAL @sentialx