feat: just enough //extensions to load a simple devtools extension#19515
Merged
feat: just enough //extensions to load a simple devtools extension#19515
Conversation
jkleinsc
requested changes
Jul 31, 2019
Member
jkleinsc
left a comment
There was a problem hiding this comment.
Overall LGTM, but can we add a test?
Contributor
Author
|
@jkleinsc good thing you asked! found a couple bugs. will work on it more tomorrow. |
ac2e616 to
ad64d21
Compare
d5efe77 to
fa2394c
Compare
Contributor
Author
|
@jkleinsc I (eventually) made a test :) I hope I fixed whatever bug it was that I was thinking about, because I've long since forgotten what I encountered. Test works though. |
11 tasks
nornagon
commented
Jan 14, 2020
Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
jkleinsc
approved these changes
Jan 14, 2020
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Depends on #19512.
Ref #19447
This adds just enough infrastructure to get a simple devtools extension loading.
Tested to be working:
"devtools_page"manifest keychrome.devtools.panels.createAPIChecklist
npm testpassesRelease Notes
Notes: none
(//extensions still not turned on)