chore: revert key -> main change in window delegate listener#19213
Merged
chore: revert key -> main change in window delegate listener#19213
Conversation
codebytere
approved these changes
Jul 12, 2019
zcbenz
approved these changes
Jul 12, 2019
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "5-0-x" cleanly; |
Contributor
|
I was unable to backport this PR to "4-2-x" cleanly; |
Contributor
|
I have automatically backported this PR to "6-0-x", please check out #19221 |
Member
Author
|
/trop run backport |
Contributor
|
@erickzhao is not authorized to run PR backports. |
Member
|
/trop run backport |
Contributor
|
The backport process for this PR has been manually initiated, here we go! :D |
Contributor
|
A maintainer has manually backported this PR to "5-0-x", please check out #19238 |
Contributor
|
A maintainer has manually backported this PR to "4-2-x", please check out #19239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #19124
Reverts #18995, which caused a regression (#19124). According to our discussion in #19128 (comment), it would be best to revert the fix for now, especially since this regression has already been backported into 4.2.X, 5.0.X, and 6.0.X.
For now, the test that I wrote in #18995 has also been commented out.
cc @codebytere @zcbenz @nornagon
Checklist
npm testpassesRelease Notes
Notes: Reverted change to focus behavior that broke Character Viewer support on macOS.