Skip to content

fix: Correct modal focus behavior on macOS#19061

Merged
codebytere merged 9 commits into4-2-xfrom
trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022
Jul 3, 2019
Merged

fix: Correct modal focus behavior on macOS#19061
codebytere merged 9 commits into4-2-xfrom
trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Jul 1, 2019

Backport of #18995

See that PR for details.

Notes: Fixed bug on macOS where the main window could be targeted for a focus event when it was disabled behind a modal.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 1, 2019
@trop trop bot mentioned this pull request Jul 1, 2019
5 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jul 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 1, 2019
@erickzhao erickzhao force-pushed the trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022 branch from cb8e7ea to c567d29 Compare July 1, 2019 23:19
@codebytere codebytere merged commit b9605cc into 4-2-x Jul 3, 2019
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Jul 3, 2019

Release Notes Persisted

Fixed bug on macOS where the main window could be targeted for a focus event when it was disabled behind a modal.

@codebytere codebytere deleted the trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022 branch July 3, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4-2-x backport This is a backport PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants