Skip to content

fix: do not mark navigations interupted with same-document navigations as aborted#18142

Merged
codebytere merged 2 commits into
5-0-xfrom
trop/5-0-x-bp-fix-do-not-mark-navigations-interupted-with-same-document-navigations-as-aborted-1556925611039
May 4, 2019
Merged

fix: do not mark navigations interupted with same-document navigations as aborted#18142
codebytere merged 2 commits into
5-0-xfrom
trop/5-0-x-bp-fix-do-not-mark-navigations-interupted-with-same-document-navigations-as-aborted-1556925611039

Conversation

@trop

@trop trop Bot commented May 3, 2019

Copy link
Copy Markdown
Contributor

Backport of #18109

See that PR for details.

Notes: Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 3, 2019
@trop trop Bot mentioned this pull request May 3, 2019
Merged
@trop trop Bot added 5-0-x backport This is a backport PR labels May 3, 2019
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label May 3, 2019
@codebytere codebytere merged commit 82bb6d4 into 5-0-x May 4, 2019
@release-clerk

release-clerk Bot commented May 4, 2019

Copy link
Copy Markdown

Release Notes Persisted

Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@codebytere codebytere deleted the trop/5-0-x-bp-fix-do-not-mark-navigations-interupted-with-same-document-navigations-as-aborted-1556925611039 branch May 4, 2019 06:09
@miniak

miniak commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

@codebytere this PR introduced a linter error due to unused variable:

npm run lint

> electron@5.0.3 lint /Volumes/Builds/github/electron-5.0/src/electron
> node ./script/lint.js && npm run lint:clang-format && npm run lint:docs


/Volumes/Builds/github/electron-5.0/src/electron/spec/api-browser-window-spec.js
  309:13  error  'data' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

can you please fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes
@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

5-0-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miniak @codebytere @MarshallOfSound