Node 12 Upgrade (5-0-x) #17752
Merged
Node 12 Upgrade (5-0-x) #17752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
zcbenz
reviewed
Apr 11, 2019
| // dependency. So to expose the unmodified Node 'fs' functionality here, | ||
| // we have to copy both 'fs' *and* 'internal/fs/streams' and modify the | ||
| // copies to depend on each other instead of on our asarified 'fs' code. | ||
| source['original-fs'].replace("require('internal/fs/streams')", "require('original-fs/streams')") |
Contributor
There was a problem hiding this comment.
The hack has been moved to our node fork due to changes of node's module loader.
4da2333 to
689f9ff
Compare
nornagon
suggested changes
Apr 12, 2019
_breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided
Member
|
What NMV does this currently include? cc @nornagon |
nornagon
approved these changes
Apr 16, 2019
deepak1556
approved these changes
Apr 16, 2019
|
Release Notes Persisted
|
MarshallOfSound
requested changes
Apr 16, 2019
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
@nornagon This needs to be NMV 70 though?
https://github.com/nodejs/node/pull/24114/files#diff-638a1790356b6a533fa41d0f6715e061R5
Contributor
|
you're totally right, whoops. |
This was referenced Apr 16, 2019
6 tasks
This was referenced Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR uses electrons
electron-node-v12.xbranch which is based on node's v12.x branch.This is however, not rebased on head of node's v12.x branch yet, but is a few commits behind the v8 7.4 merge in node.
Future PRs will rebase on latest node v12.x commits.
Checklist
npm testpassesRelease Notes
Notes: Upgraded to node-12 with v8 7.3