Skip to content

refactor: prevent node macros from overriding base (backport: 5-0-x) #17739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trop wants to merge 1 commit into from
Closed

refactor: prevent node macros from overriding base (backport: 5-0-x) #17739

trop wants to merge 1 commit into from

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Apr 10, 2019

Backport of #17178

See that PR for details.

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 10, 2019
@trop trop bot mentioned this pull request Apr 10, 2019
Merged
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Apr 10, 2019
@zcbenz
Copy link
Contributor

zcbenz commented Apr 10, 2019

This is needed for upgrading to Node 12 in 5-0-x, which is required for fixing #17309.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 10, 2019
@zcbenz zcbenz closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

5-0-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zcbenz @nornagon