Skip to content

test: fix flaky takeHeapSnapshot test#15853

Merged
alexeykuzmin merged 1 commit into
masterfrom
fix-flaky-takeheapsnapshot-test
Nov 29, 2018
Merged

test: fix flaky takeHeapSnapshot test#15853
alexeykuzmin merged 1 commit into
masterfrom
fix-flaky-takeheapsnapshot-test

Conversation

@nornagon

@nornagon nornagon commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

My suspicion is that the 'load' event is getting emitted before we start waiting for it.

Fixes #15095

Notes: no-notes

@nornagon nornagon requested a review from a team November 27, 2018 19:29
@nornagon nornagon changed the title test: attempt at fixing flaky takeHeapSnapshotTest test: fix flaky takeHeapSnapshotTest Nov 28, 2018
@nornagon nornagon changed the title test: fix flaky takeHeapSnapshotTest test: fix flaky takeHeapSnapshot test Nov 28, 2018
@alexeykuzmin

Copy link
Copy Markdown
Contributor

/cc @miniak

@alexeykuzmin alexeykuzmin merged commit 753fb31 into master Nov 29, 2018
@release-clerk

release-clerk Bot commented Nov 29, 2018

Copy link
Copy Markdown

No Release Notes

@alexeykuzmin alexeykuzmin deleted the fix-flaky-takeheapsnapshot-test branch November 29, 2018 15:51
@alexeykuzmin

Copy link
Copy Markdown
Contributor

/trop run backport

@trop

trop Bot commented Nov 29, 2018

Copy link
Copy Markdown
Contributor

The backport process for this PR has been manually initiated, here we go! :D

@trop

trop Bot commented Nov 29, 2018

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "4-0-x", please check out #15881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants