Skip to content

Backport (2-0-x) - fix: prevent bundles from being selected in <input file="type"> open file dialog (macOS)#13277

Merged
ckerr merged 1 commit into2-0-xfrom
miniak/open-dialog-fix-2-0-x
Jun 18, 2018
Merged

Backport (2-0-x) - fix: prevent bundles from being selected in <input file="type"> open file dialog (macOS)#13277
ckerr merged 1 commit into2-0-xfrom
miniak/open-dialog-fix-2-0-x

Conversation

@miniak
Copy link
Copy Markdown
Contributor

@miniak miniak commented Jun 18, 2018

Backport: #13220

@miniak miniak requested a review from a team June 18, 2018 09:17
@ckerr ckerr merged commit a09fa53 into 2-0-x Jun 18, 2018
@ckerr ckerr deleted the miniak/open-dialog-fix-2-0-x branch June 18, 2018 15:34
@yume-chan
Copy link
Copy Markdown

You have (almost) broken the Electron release page:

https://electronjs.org/releases#2.0.3

image

But you made a typo, <input file="type"> should be <input type="file">, and it now displays as a text input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants