Skip to content

Issue with BrowserWindow height in Mac OS X #1024

@unindented

Description

@unindented

If I instantiate BrowserWindow on Mac OS X Mavericks with height: 384, frame: true, I get a window with height 384px, including title bar. My content is 384px high, so the bottom gets cut:

With frame

If I instantiate BrowserWindow with height: 384, frame: false, I get a window with height 406px (notice the empty stripe at the bottom of the image):

Without frame

It looks like an if statement somewhere is checking for the opposite condition. If frame: true, then the window should be 406px (384px from the content + 22px from the title bar). Otherwise, the window should be 384px (just the content). Currently the opposite happens.

Am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions