fix: always call the original impl in swizzled mousedown impls (#50355)

trop[bot] · nmggithub · web-flow · commit 00827a2da491 · 2026-03-18T20:49:10.000-07:00
fix: always call the original implementation in swizzled mousedown implementations

Co-authored-by: trop[bot] &lt;37223003+trop[bot]@users.noreply.github.com&gt;
Co-authored-by: Noah Gregory &lt;noahmgregory@gmail.com&gt;
diff --git a/shell/browser/ui/cocoa/electron_ns_window.mm b/shell/browser/ui/cocoa/electron_ns_window.mm
@@ -87,8 +87,8 @@ - (void)swiz_nsthemeframe_mouseDown:(NSEvent*)event {
         (electron::NativeWindowMac*)[(id)self.window shell];
     if (shell && !shell->has_frame())
       [self cr_mouseDownOnFrameView:event];
-    g_nsthemeframe_mousedown(self, @selector(mouseDown:), event);
   }
+  g_nsthemeframe_mousedown(self, @selector(mouseDown:), event);
 }
 
 - (void)swiz_nsnextstepframe_mouseDown:(NSEvent*)event {
@@ -98,8 +98,8 @@ - (void)swiz_nsnextstepframe_mouseDown:(NSEvent*)event {
     if (shell && !shell->has_frame()) {
       [self cr_mouseDownOnFrameView:event];
     }
-    g_nsnextstepframe_mousedown(self, @selector(mouseDown:), event);
   }
+  g_nsnextstepframe_mousedown(self, @selector(mouseDown:), event);
 }
 
 - (void)swiz_nsview_swipeWithEvent:(NSEvent*)event {

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,8 @@ - (void)swiz_nsthemeframe_mouseDown:(NSEvent*)event {`
`87`	`87`	`(electron::NativeWindowMac*)[(id)self.window shell];`
`88`	`88`	`if (shell && !shell->has_frame())`
`89`	`89`	`[self cr_mouseDownOnFrameView:event];`
`90`		`- g_nsthemeframe_mousedown(self, @selector(mouseDown:), event);`
`91`	`90`	`}`
	`91`	`+ g_nsthemeframe_mousedown(self, @selector(mouseDown:), event);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`- (void)swiz_nsnextstepframe_mouseDown:(NSEvent*)event {`
`@@ -98,8 +98,8 @@ - (void)swiz_nsnextstepframe_mouseDown:(NSEvent*)event {`
`98`	`98`	`if (shell && !shell->has_frame()) {`
`99`	`99`	`[self cr_mouseDownOnFrameView:event];`
`100`	`100`	`}`
`101`		`- g_nsnextstepframe_mousedown(self, @selector(mouseDown:), event);`
`102`	`101`	`}`
	`102`	`+ g_nsnextstepframe_mousedown(self, @selector(mouseDown:), event);`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`- (void)swiz_nsview_swipeWithEvent:(NSEvent*)event {`