chore: deprecate CHROMIUM_BUILDTOOLS_PATH#859
Merged
Conversation
71e64ee to
8143a3d
Compare
8143a3d to
d9becca
Compare
Assisted-by: Claude Opus 4.6
d9becca to
d1ee01b
Compare
3 tasks
jkleinsc
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #855, when paired with electron/electron#51558. This PR checks if
depot_toolshas the fix to findsrc/buildtoolswith Electron, and if so it removes theCHROMIUM_BUILDTOOLS_PATHenvironment variable.In the future we'll rip out the
CHROMIUM_BUILDTOOLS_PATHlogic all together once enough time has passed with the upstreamdepot_toolsfix having landed.