fix: properly handle target argument in e build#351
Merged
codebytere merged 1 commit intoelectron:mainfrom Mar 22, 2022
Merged
Conversation
codebytere
approved these changes
Mar 22, 2022
Member
codebytere
left a comment
There was a problem hiding this comment.
Thanks! and yeah - definitely collateral damage from the commander upgrade 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is fall out from the commander upgrade (seems plausible given the code's usage of
rawArgs), but currently providing a target argument toe buildisn't working since it doesn't map it to the correct name.This tightens up the different ways a target can be provided and I think handles all cases robustly now.
Came from electron/electron#33355 where it was showing up in the wild.
@codebytere