fix: Return undefined when no version is found

pvdlg · pvdlg · commit b78535ed2cd6 · 2017-11-29T22:40:25.000-05:00
diff --git a/lib/get-last-release.js b/lib/get-last-release.js
@@ -19,7 +19,7 @@ module.exports = async ({publishConfig, name}, logger) => {
     const data = await promisify(client.get.bind(client))(uri, {auth});
     if (data && !data['dist-tags']) {
       logger.log('No version found of package %s found on %s', name, registry);
-      return {};
+      return;
     }
     const distTags = data['dist-tags'];
     let version;
@@ -34,7 +34,7 @@ module.exports = async ({publishConfig, name}, logger) => {
   } catch (err) {
     if (err.statusCode === 404 || /not found/i.test(err.message)) {
       logger.log('No version found of package %s found on %s', name, registry);
-      return {};
+      return;
     }
     throw err;
   }
diff --git a/test/get-last-release.test.js b/test/get-last-release.test.js
@@ -94,7 +94,7 @@ test.serial('Get nothing from completely unpublished package name', async t => {
   const registryMock = mock(name).reply(200, unpublishedModule);
   const release = await lastRelease({name, publishConfig: {registry}}, t.context.logger);
 
-  t.is(release.version, undefined);
+  t.falsy(release);
   t.true(registryMock.isDone());
 });
 
@@ -103,7 +103,7 @@ test.serial('Get nothing from not yet published package name (unavailable)', asy
   const registryMock = mock(name).reply(404, {});
   const release = await lastRelease({name, publishConfig: {registry}}, t.context.logger);
 
-  t.is(release.version, undefined);
+  t.falsy(release);
   t.true(registryMock.isDone());
 });
 
@@ -112,7 +112,7 @@ test.serial('Get nothing from not yet published package name (unavailable w/o re
   const registryMock = mock(name).reply(404);
   const release = await lastRelease({name, publishConfig: {registry}}, t.context.logger);
 
-  t.is(release.version, undefined);
+  t.falsy(release);
   t.true(registryMock.isDone());
 });
 
@@ -135,7 +135,7 @@ test.serial('Get nothing from not yet published package name (unavailable w/o st
   await appendFile('./.npmrc', 'fetch-retry-factor = 1\nfetch-retry-mintimeout = 1\nfetch-retry-maxtimeout = 1');
   const release = await lastRelease({name, publishConfig: {registry}}, t.context.logger);
 
-  t.is(release.version, undefined);
+  t.falsy(release);
   t.true(registryMock.isDone());
 });
 
diff --git a/test/integration.test.js b/test/integration.test.js
@@ -95,7 +95,7 @@ test.serial('Return nothing if no version if published', async t => {
   await writeJson('./package.json', pkg);
   const nextRelease = await t.context.m.getLastRelease({}, {logger: t.context.logger});
 
-  t.deepEqual(nextRelease, {});
+  t.falsy(nextRelease);
 });
 
 test.serial('Return last version published', async t => {
@@ -155,7 +155,7 @@ test.serial('Return nothing for an unpublished package', async t => {
   await execa('npm', ['unpublish', 'unpublished', '--force']);
 
   const nextRelease = await t.context.m.getLastRelease({}, {logger: t.context.logger});
-  t.deepEqual(nextRelease, {});
+  t.falsy(nextRelease);
 });
 
 test.serial('Publish a package', async t => {
@@ -176,7 +176,7 @@ test.serial('Verify token and set up auth only on the fist call', async t => {
   await t.notThrows(t.context.m.verifyConditions({}, {logger: t.context.logger}));
 
   let nextRelease = await t.context.m.getLastRelease({}, {logger: t.context.logger});
-  t.deepEqual(nextRelease, {});
+  t.falsy(nextRelease);
 
   await t.context.m.publish({}, {logger: t.context.logger, nextRelease: {version: '1.0.0'}});
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ module.exports = async ({publishConfig, name}, logger) => {`
`19`	`19`	`const data = await promisify(client.get.bind(client))(uri, {auth});`
`20`	`20`	`if (data && !data['dist-tags']) {`
`21`	`21`	`logger.log('No version found of package %s found on %s', name, registry);`
`22`		`- return {};`
	`22`	`+ return;`
`23`	`23`	`}`
`24`	`24`	`const distTags = data['dist-tags'];`
`25`	`25`	`let version;`
`@@ -34,7 +34,7 @@ module.exports = async ({publishConfig, name}, logger) => {`
`34`	`34`	`} catch (err) {`
`35`	`35`	`if (err.statusCode === 404 \|\| /not found/i.test(err.message)) {`
`36`	`36`	`logger.log('No version found of package %s found on %s', name, registry);`
`37`		`- return {};`
	`37`	`+ return;`
`38`	`38`	`}`
`39`	`39`	`throw err;`
`40`	`40`	`}`