fix: return false in addChannel if package is not published on npm

pvdlg · pvdlg · commit 5434babb96f6 · 2018-12-14T18:45:13.000-05:00
diff --git a/lib/add-channel.js b/lib/add-channel.js
@@ -42,4 +42,6 @@ module.exports = async ({npmPublish}, pkg, context) => {
       npmPublish === false ? 'npmPublish' : "package.json's private property"
     } is ${npmPublish !== false}`
   );
+
+  return false;
 };
diff --git a/test/integration.test.js b/test/integration.test.js
@@ -634,7 +634,7 @@ test('Skip adding the package to a channel ("npmPublish" is false)', async t =>
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));
 });
 
@@ -662,7 +662,7 @@ test('Skip adding the package to a channel ("package.private" is true)', async t
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));
 });
 

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ test('Skip adding the package to a channel ("npmPublish" is false)', async t =>`
`634`	`634`	`}`
`635`	`635`	`);`
`636`	`636`
`637`		`- t.falsy(result);`
	`637`	`+ t.false(result);`
`638`	`638`	`await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));`
`639`	`639`	`});`
`640`	`640`
`@@ -662,7 +662,7 @@ test('Skip adding the package to a channel ("package.private" is true)', async t`
`662`	`662`	`}`
`663`	`663`	`);`
`664`	`664`
`665`		`- t.falsy(result);`
	`665`	`+ t.false(result);`
`666`	`666`	`await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env}));`
`667`	`667`	`});`
`668`	`668`