-
Notifications
You must be signed in to change notification settings - Fork 6
Go full Async #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
And on Core 2.1 preview |
|
I'm reviewing the code now. Thanks for your submission. |
|
I can rebase? There should hopefully be no slow down from the full async in this PR? |
|
Rebasing has hit the performance; looking it it |
|
There's something definitely wrong with FileStream in async mode... Anyway, current - everything async other than FileStream Switch FileStream to async |
|
Raised issue https://github.com/dotnet/corefx/issues/29129 |
|
Let's do some more investigation first. @benaadams your async tests aren't exactly at parity with the synchronous ones. |
|
There's a stack overflow I've seen before about FileStream async. I'd search for that. There may not be anything wrong. |
|
After my refactor, here's the results I'm getting. Synchronous tests have to remain as a benchmark. |
|
https://github.com/electricessence/AsyncFileWriter/blob/master/AsyncFileWriterTester/AsyncTester.cs#L61 |
Is currently blocking in some of the paths; making it fully async gives no significant drop off and the
FileStreamcan then also be async.