Skip to content

Reload cron workflows after workflow updates#397

Merged
marccampbell merged 2 commits into
mainfrom
fix-reload-cron-workflows
Jun 10, 2026
Merged

Reload cron workflows after workflow updates#397
marccampbell merged 2 commits into
mainfrom
fix-reload-cron-workflows

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

Summary

  • load cron schedules from external workspace storage, matching the workspace/workflow APIs
  • reload the cron scheduler after workflow push and workflow patch
  • add regression coverage for cron registration on push and removal when disabled

Why

Pushed cron workflows could validate and persist but not run until the scheduler saw them. In practice the scheduler was also reading a legacy workspace table rather than the external workspace files used by workflow push.

Tests

  • go test ./pkg/hub
  • make test

@marccampbell marccampbell force-pushed the fix-reload-cron-workflows branch from 518c903 to 3964e58 Compare June 10, 2026 20:45
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Reload cron workflows after workflow upd..." | Re-trigger Greptile

Comment thread pkg/hub/cron_scheduler.go
Comment thread pkg/hub/workspace_api.go
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Handle cron reload edge cases" | Re-trigger Greptile

@marccampbell marccampbell merged commit 66c1a22 into main Jun 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant