Skip to content

Require admin auth for config mutations#395

Merged
marccampbell merged 2 commits into
mainfrom
fix/admin-only-config-mutations
Jun 10, 2026
Merged

Require admin auth for config mutations#395
marccampbell merged 2 commits into
mainfrom
fix/admin-only-config-mutations

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

Summary

  • require web admin auth for mutating factory, workspace, workflow, secret, GitHub App, and issue tracker config routes
  • keep read and manual trigger routes on normal authenticated access
  • add auth helper and route-level tests covering regular GitHub users being blocked from config mutations

Tests

  • env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hub -run 'TestWebAdminAuthRequiresAccessAdminForGitHubSession|TestAdminForMethodsRequiresAdminForMutations|TestConfigMutationRoutesRequireWebAdminForGitHubSessions'
  • env GOCACHE=/private/tmp/elasticclaw-go-build go test ./...

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Require admin auth for config mutations" | Re-trigger Greptile

Comment thread pkg/hub/server.go
Comment thread pkg/hub/server_test.go
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Address config mutation auth review" | Re-trigger Greptile

@marccampbell marccampbell force-pushed the fix/admin-only-config-mutations branch from 6bd2325 to 98bcd66 Compare June 10, 2026 17:26
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (3): Last reviewed commit: "Address config mutation auth review" | Re-trigger Greptile

@marccampbell marccampbell merged commit 856b47d into main Jun 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants