Fix Daytona bridge command quoting#394
Merged
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "Fix Daytona bridge command quoting" | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "Address Daytona bridge review feedback" | Re-trigger Greptile |
AnaBerg
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the critical command-injection finding from
SECURITY-REVIEW.md.daytonaAsyncBridgeCommandused Go%qformatting for shell environment assignments. Go double-quoted literals are not shell-safe: command substitutions such as$(...)still execute inside shell double quotes. The Daytona bridge launch path now uses the existing single-quoteshellQuotehelper for hub URL, claw ID, claw token, and claw name, matching the safer replicated bootstrap path.Test coverage
shellQuoteand does not place it in a shell double-quoted assignment.Validation
env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hub -run 'TestDaytonaBridgeCommands_AreAsyncAndIdempotent|TestDaytonaAsyncBridgeCommandShellQuotesClawName'env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hubenv GOCACHE=/private/tmp/elasticclaw-go-build go test ./...