Skip to content

Preserve workflow gates and parse noisy run outputs#380

Merged
marccampbell merged 2 commits into
mainfrom
fix-workflow-gates-noisy-json
Jun 7, 2026
Merged

Preserve workflow gates and parse noisy run outputs#380
marccampbell merged 2 commits into
mainfrom
fix-workflow-gates-noisy-json

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

Summary

  • Preserve stage gate blocks when normalizing workspace workflow YAML into runtime pipeline YAML.
  • Parse the final JSON object line from workflow run stdout so noisy scripts can still produce structured gate outputs.
  • Add regression coverage for normalized workflow gates and noisy CodeBuild-style stdout.

Why
In prod, the android_validation run command executed and persisted output, but no gate evaluated and the UI stayed silent. The workspace workflow file had a gate, but types.WorkflowStage did not carry gate through normalization, so runtime pipeline YAML dropped it. The same output showed shell trace lines before the JSON status, which made parsed_json become an empty object.

Verification

  • go test ./pkg/types ./pkg/hub -run targeted workflow and output parser tests
  • go test ./...

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Preserve workflow gates and parse noisy ..." | Re-trigger Greptile

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Add deterministic workflow gate E2E cove..." | Re-trigger Greptile

@marccampbell marccampbell merged commit ef0aae9 into main Jun 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant