Skip to content

Stage workspace scripts in claws#379

Merged
marccampbell merged 3 commits into
mainfrom
fix-workspace-script-staging
Jun 7, 2026
Merged

Stage workspace scripts in claws#379
marccampbell merged 3 commits into
mainfrom
fix-workspace-script-staging

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Stage workspace scripts in claws" | Re-trigger Greptile

Comment thread pkg/hub/server.go Outdated
Comment thread pkg/config/hub.go Outdated
@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff (1)

  1. pkg/hub/server.go, line 5138-5152 (link)

    P1 The two call sites pass paths containing the shell variable $HOME"$HOME/workspace" (flake files) and "$HOME/.openclaw/workspace" (template files). shellQuote wraps the full string in single quotes, which suppresses variable expansion in the remote shell. So mkdir -p '$HOME/.openclaw/workspace' creates a literal directory named $HOME relative to the SSH session's CWD, not the user's home directory. The flake-file call treats this as a fatal error and aborts bootstrap; the template-file call retries three times then logs a warning. Either way, the files land in the wrong place or are not written at all. The daytona bootstrap path avoids this by using a hardcoded absolute path (/home/daytona/.openclaw/workspace/); the same approach should be taken here.

Reviews (2): Last reviewed commit: "Address workspace script staging review" | Re-trigger Greptile

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Reviews (3): Last reviewed commit: "Address SSH workspace path review" | Re-trigger Greptile

@marccampbell marccampbell merged commit cae571a into main Jun 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant