Prioritize workflow [DONE] triggers before legacy completion#378
Conversation
|
Reviews (1): Last reviewed commit: "Prioritize pipeline done triggers" | Re-trigger Greptile |
| t.Fatalf("insert claw: %v", err) | ||
| } | ||
|
|
||
| s.handleClawDoneSignal(clawID, "[DONE]") |
There was a problem hiding this comment.
The regression test calls s.handleClawDoneSignal(clawID, "[DONE]") directly, which exercises the new early-return added to handleClawDoneSignal. However, the real production fix is in handleClawWS (server.go), which now sets pipelineHandledDone and routes to checkPipelineMessageTriggers — meaning handleClawDoneSignal is never reached in the described scenario. The test therefore covers a defense-in-depth path that production code never hits, while leaving the server.go routing logic (the actual fix) without any integration test.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Reviews (2): Last reviewed commit: "Track pipeline done signals from websock..." | Re-trigger Greptile |
|
Reviews (3): Last reviewed commit: "Merge main into done trigger branch" | Re-trigger Greptile |
Summary
message_contains: "[DONE]"triggers run instead of skipping them in the websocket message path[DONE]signal[DONE]that advances to an Android validation stage without injecting the no-PR warningFinding
The CodeBuild stage did not run because
handleClawWSonly evaluated pipeline message triggers for non-[DONE]messages. The same message then fell through tohandleClawDoneSignal, which validates legacy factory completion and injected the "no PR URLs" prompt before the workflow could transition toandroid_validation.Tests
env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hubenv GOCACHE=/private/tmp/elasticclaw-go-build go test ./...