Skip to content

Fix settings workspace route loop#367

Merged
marccampbell merged 2 commits into
mainfrom
fix-settings-workspace-static-loop
Jun 6, 2026
Merged

Fix settings workspace route loop#367
marccampbell merged 2 commits into
mainfrom
fix-settings-workspace-static-loop

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

Summary

  • derive settings route parts from the actual browser pathname when available
  • avoid treating production static-export fallback HTML for _workspace as the active workspace route
  • prevent same-URL router.replace loops on real workspace settings URLs such as /settings/faster/workflows

Tests

  • npm run build (from web/)

@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Fix settings workspace route loop" | Re-trigger Greptile

Comment thread web/app/settings/[[...parts]]/settings-content.tsx Outdated
@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Avoid double-decoding settings route par..." | Re-trigger Greptile

@marccampbell marccampbell merged commit c8de96f into main Jun 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant