feat(replicated): clarify file/env injection contract with explicit errors#364
Conversation
|
Greptile review caught that ProvisionClaw's docstring claimed env was 'passed through to the bootstrap script' but the implementation silently dropped it. Now both templateFiles and env are explicitly rejected with clear errors, matching the Create() pattern. - Added env rejection guard in ProvisionClaw() - Rewrote docstring to accurately describe the contract - Added tests for env rejection and combined rejection Addresses #364 (comment)
|
Reviews (2): Last reviewed commit: "fix(replicated): reject env in Provision..." | Re-trigger Greptile |
…rrors The Replicated CMX provider cannot inject TemplateFiles or Env at creation time because the VM must be running before SSH is available. The hub's bootstrapReplicated path already handles file injection separately after the VM is running. This change makes the contract explicit: - Create() now returns an error if TemplateFiles or Env are provided - ProvisionClaw() now returns an error if templateFiles are provided - Added provider-level tests for the error behavior - Added documentation comments explaining the limitation Fixes #300
Greptile review caught that ProvisionClaw's docstring claimed env was 'passed through to the bootstrap script' but the implementation silently dropped it. Now both templateFiles and env are explicitly rejected with clear errors, matching the Create() pattern. - Added env rejection guard in ProvisionClaw() - Rewrote docstring to accurately describe the contract - Added tests for env rejection and combined rejection Addresses #364 (comment)
dbd6df6 to
007639f
Compare
|
Reviews (3): Last reviewed commit: "Defer replicated env injection during pr..." | Re-trigger Greptile |
Fixes #300
The Replicated CMX provider cannot inject TemplateFiles or Env at creation time because the VM must be running before SSH is available. The hub's bootstrapReplicated path already handles file injection separately after the VM is running.
This change makes the contract explicit rather than silently ignoring data: