fix: make external webhook trigger creation atomic#349
Merged
Conversation
Replace the non-atomic findClawForExternalTrigger check with the existing factory_triggers claim/complete mechanism. This prevents concurrent webhook deliveries from racing and creating duplicate claws for the same factory/external_trigger_id. Changes: - processExternalEvent: use claimFactoryTrigger before createClawForExternalEvent - createClawForExternalEvent: return (clawID, error) instead of just error - Remove findClawForExternalTrigger (non-atomic, now unnecessary) - Treat duplicate claims as idempotent success (already claimed = no error) - Add concurrent delivery regression test Fixes #299
Contributor
|
Reviews (1): Last reviewed commit: "fix: make external webhook trigger creat..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "Scope external trigger claim cleanup" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299
Replace the non-atomic
findClawForExternalTriggercheck with the existingfactory_triggersclaim/complete mechanism. This prevents concurrent webhook deliveries from racing and creating duplicate claws for the same factory/external_trigger_id.Changes
processExternalEvent: useclaimFactoryTriggerbeforecreateClawForExternalEventcreateClawForExternalEvent: return(clawID, error)instead of justerrorfindClawForExternalTrigger(non-atomic, now unnecessary)Verification
go build ./pkg/hub/...passesgo test ./pkg/hub/...passesgo test -tags integration -run TestExternalWebhook -count=1 -v ./pkg/hub/...passes