Recover bridge sessions after context overflow#344
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "Recover bridge sessions after context ov..." | Re-trigger Greptile |
Comment on lines
+1443
to
+1448
| retryCtx := ctx | ||
| retryCancel := func() {} | ||
| if ctx.Err() != nil { | ||
| retryCtx, retryCancel = context.WithTimeout(context.Background(), 30*time.Minute) | ||
| } | ||
| defer retryCancel() |
Contributor
There was a problem hiding this comment.
When ctx.Err() != nil, the original request was already cancelled or timed out by the caller. Instead of aborting, this branch silently discards the caller's intent and retries with a brand-new context.WithTimeout(..., 30*time.Minute). For a legitimate server-side deadline error the original context should still be valid; the ctx.Err() != nil branch should return early rather than substitute a new context.
Contributor
|
Reviews (2): Last reviewed commit: "Respect caller cancellation during sessi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests