feat: workspace scripts with workflow output capture (#342)#343
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
2d2ed37 to
6877495
Compare
Contributor
|
Reviews (2): Last reviewed commit: "feat: workspace scripts with workflow ou..." | Re-trigger Greptile |
6877495 to
d541187
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d541187 to
60e366c
Compare
- Add scripts/ directory discovery to ReadTemplateFiles for template delivery
- Add Output field to pipeline.RunAction for named output capture
- Add pipeline_outputs DB table with JSON parsing and persistence
- Implement persistPipelineOutput and loadPipelineOutputs methods
- Make outputs available in template rendering via {{ .Outputs.name.key }}
- Add path traversal validation for workflow script commands (rejects any token
containing .., including inline flag values like --output=../../etc/passwd)
- Fix injectTemplateData to unconditionally set Outputs after merging baseData
- Fix loadPipelineOutputs to check rows.Err() after iteration
- Add comprehensive tests for output capture, persistence, and script delivery
60e366c to
1d56434
Compare
Contributor
|
Reviews (4): Last reviewed commit: "fix: add db migration comment for pipeli..." | Re-trigger Greptile |
Contributor
|
Reviews (5): Last reviewed commit: "chore: re-trigger CI" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #342 — Add workspace scripts with workflow output capture.
Changes
Script Delivery
Output Capture
Template Integration
Security
Tests