You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sendNextQueuedMessage duplicates the busy-check inline instead of calling the new isBusyLocked() helper. If the predicate ever changes (e.g. a third field is added to the busy state), this copy would silently diverge.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
delivered flag and "delivered" log are misleading in the failure branch
delivered = true is set unconditionally in both the happy path and the error path (after re-queuing a failed write). The subsequent log.Printf("[pr-watcher] delivered injected message …") then fires even though the message was only prepended to the retry queue. During incident investigation, a log that says "delivered" when the message was actually queued-after-failure can send debugging in the wrong direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests