fix: use localStorage for auth tokens to enable cross-tab sessions#335
Merged
Conversation
Previously auth tokens were stored in sessionStorage, which is scoped to a single browser tab. This meant users had to re-authenticate in every new tab. - Create web/lib/auth-storage.ts as a centralized auth storage helper - Switch token storage from sessionStorage to localStorage - Keep OAuth CSRF state in sessionStorage (it should be per-tab) - Update all direct sessionStorage reads/writes to use the helper: - web/lib/api.ts (resolveToken, getTokenSync, clearConfig) - web/app/login/page.tsx (login + OAuth callback) - web/app/page.tsx (admin status check) - web/components/sidebar.tsx (logout) - web/hooks/use-branding.ts (branding fetch) - web/app/settings/[[...parts]]/settings-content.tsx (all settings API calls) Fixes #329
Contributor
|
Contributor
|
Reviews (2): Last reviewed commit: "Address cross-tab auth review feedback" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
Previously auth tokens were stored in sessionStorage, which is scoped to a single browser tab. This meant users had to re-authenticate in every new tab.
Changes
web/lib/auth-storage.tsas a centralized auth storage helperweb/lib/api.ts(resolveToken, getTokenSync, clearConfig)web/app/login/page.tsx(login + OAuth callback)web/app/page.tsx(admin status check)web/components/sidebar.tsx(logout)web/hooks/use-branding.ts(branding fetch)web/app/settings/[[...parts]]/settings-content.tsx(all settings API calls)Verification
npx next buildpasses (TypeScript + static generation)go build ./...passes