fix: make web lint script self-contained (#305)#333
Merged
Conversation
07c262d to
68621eb
Compare
Contributor
|
Reviews (1): Last reviewed commit: "fix: make web lint script self-contained" | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "fix: make web lint script self-contained" | Re-trigger Greptile |
- Add eslint and eslint-config-next as devDependencies in web/package.json - Add eslint.config.mjs flat config using eslint-config-next preset - Add lint step to CI web build job Fixes #305
68621eb to
2368579
Compare
Contributor
|
Reviews (3): Last reviewed commit: "fix: make web lint script self-contained" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from PR #297.
Problem:
web/package.jsonexposesnpm run lintaseslint ., buteslintis not declared as a dependency. A clean install fails unless eslint is globally installed or hoisted externally.Changes:
eslintandeslint-config-nextas devDependencies inweb/package.jsonweb/eslint.config.mjsflat config using the standard Next.js presetnpm run lintstep to the CI web build job in.depot/workflows/test.yamlVerification:
npm installsucceeds,npm run lintruns without "command not found" errorsFixes #305