Skip to content

Ignore missing GitHub labels on removal#332

Merged
marccampbell merged 2 commits into
mainfrom
ignore-missing-github-label-remove
Jun 2, 2026
Merged

Ignore missing GitHub labels on removal#332
marccampbell merged 2 commits into
mainfrom
ignore-missing-github-label-remove

Conversation

@marccampbell

Copy link
Copy Markdown
Contributor

Summary

  • Treat GitHub's missing-label 404 response as a successful no-op when removing issue labels
  • Add a regression test for deleting an absent label

Tests

  • env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hub -run 'TestGitHubAPIDeleteLabelIgnoresMissingLabel|TestTransitionPipelineStage'
  • env GOCACHE=/private/tmp/elasticclaw-go-build go test ./pkg/hub

@greptile-apps

greptile-apps Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Ignore missing GitHub labels on removal" | Re-trigger Greptile

Comment thread pkg/hub/pipeline_runner_test.go
@greptile-apps

greptile-apps Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "Address missing label test review" | Re-trigger Greptile

@marccampbell marccampbell merged commit 576ec49 into main Jun 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant