Skip to content

fix: ensure journey/end is written to fd#447

Merged
vigneshshanmugam merged 2 commits intoelastic:mainfrom
vigneshshanmugam:flush-last-bytes
Jan 29, 2022
Merged

fix: ensure journey/end is written to fd#447
vigneshshanmugam merged 2 commits intoelastic:mainfrom
vigneshshanmugam:flush-last-bytes

Conversation

@vigneshshanmugam
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam commented Jan 28, 2022

vigneshshanmugam
vigneshshanmugam commented Jan 28, 2022
View reviewed changes
@ghost
Copy link
Copy Markdown

ghost commented Jan 28, 2022 •
edited by ghost
Loading

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-29T01:44:40.406+0000

  • Duration: 32 min 48 sec

  • Commit: fd044bb

Test stats 🧪

Test Results
Failed 0
Passed 142
Skipped 2
Total 144

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vigneshshanmugam
Copy link
Copy Markdown
Member Author

vigneshshanmugam commented Jan 28, 2022

E2E test failure is due to this current bug we have as in Heartbeat summary docs is not generated and the current 8.x snapshot image contains the previous version of Synthetics which stops the Uptime journey files from running and hanging forever.

synthetics/__tests__/e2e/uptime.journey.ts

Lines 67 to 93 in 201f7da

async function waitForSyntheticsData() {
console.log('Waiting for Synthetics to send data to ES for test monitor');
let status = false;
while (!status) {
try {
const { data } = await axios.post(
'http://localhost:9220/heartbeat-*/_search',
{
query: {
bool: {
filter: [
{
term: {
'monitor.id': 'my-monitor-inline',
},
},
{
exists: {
field: 'summary',
},
},
],
},
},
}
);

@dominiqueclarke dominiqueclarke self-requested a review January 28, 2022 21:17
andrewvc
andrewvc approved these changes Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dominiqueclarke
dominiqueclarke approved these changes Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vigneshshanmugam vigneshshanmugam merged commit d821f5b into elastic:main Jan 29, 2022
@vigneshshanmugam vigneshshanmugam deleted the flush-last-bytes branch January 29, 2022 04:57
@vigneshshanmugam vigneshshanmugam mentioned this pull request Feb 3, 2022
Closed
@shahzad31 shahzad31 mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvc andrewvc andrewvc approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reporter stream buffer is not emptied in all cases Debug logs should not go to special FD (3)

3 participants

@vigneshshanmugam @andrewvc @dominiqueclarke