Re-add support for suite params#379
Merged
andrewvc merged 5 commits intoelastic:masterfrom Sep 16, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
src/parse_args.ts
Outdated
| ) | ||
| .option( | ||
| '-p, --params <jsonstring>', | ||
| '-p, --params <jsonstring>, --suite-params <jsonstring>', |
Member
There was a problem hiding this comment.
I am confused with this notation, What does this do?
Contributor
Author
There was a problem hiding this comment.
Oops, let me remove it. It does nothing. You can't add a third form of the command, I needed to add a new option below.
Member
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Overall I feel like we can take the changes from the previous PR https://github.com/elastic/synthetics/pull/331/files and add the test we have here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heartbeat 7.15/7.x did not get elastic/beats#26674 backported to them. Since they will be released soon we need to work on re-supporting the
--suite-paramsflag and do a new release once this is merged.