Add synthetics capabilities env var to Dockerfile#159
Merged
andrewvc merged 1 commit intoelastic:masterfrom Dec 3, 2020
Merged
Add synthetics capabilities env var to Dockerfile#159andrewvc merged 1 commit intoelastic:masterfrom
andrewvc merged 1 commit intoelastic:masterfrom
Conversation
As part of bringing synthetics to beta we want to merge the special heatbeat branch to master. We still, however, want to restrict synthetics usage to the synthetics docker image to prevent users from getting confusing errors running synthetics on a plain system. This env var can be checked by heartbeat before activating any synthetics monitors.
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
hmdhk
approved these changes
Dec 3, 2020
Contributor
hmdhk
left a comment
There was a problem hiding this comment.
LGTM, however the e2e tests are failing, I had a brief look, it seems the docker container didn't run properly (might be unrelated to these changes though)
Contributor
Author
|
@jahtalab you're right that the E2E test failure is unrelated I'll take a look at it. Will merge this regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of bringing synthetics to beta we want to merge the special heatbeat branch to master. We still, however, want to restrict synthetics usage to the synthetics docker image to prevent users from getting confusing errors running synthetics on a plain system. This env var can be checked by heartbeat before activating any synthetics monitors.
Goes toward #140