Skip to content

Documents built-in beats_admin role#80

Merged
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:x-pack/management/beats
Jul 10, 2018
Merged

Documents built-in beats_admin role#80
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:x-pack/management/beats

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Jul 10, 2018

This role is require for Beats central management and was added to X-Pack Elasticsearch as part of elastic/elasticsearch#30520.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Jul 10, 2018

@dedemorton Would you mind reviewing this? Commenting here as I don't seem to have GitHub repo rights to directly request your review. Thanks!

@ycombinator ycombinator mentioned this pull request Jul 10, 2018
Merged
@lcawl lcawl requested review from dedemorton and lcawl July 10, 2018 15:06
lcawl
lcawl reviewed Jul 10, 2018
View reviewed changes
docs/en/stack/security/authorization/built-in-roles.asciidoc Outdated
suitable for use within a Logstash pipeline.

[[built-in-roles-beats-admin]] `beats_admin` ::
Grants access to the `.management-beats` index for managing configurations.
Copy link
Copy Markdown
Contributor

@lcawl lcawl Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this matches the logstash_admin description, my two cents is that it might be clearer to say something like this:
"... index, which contains configuration information for the Beats".

jaymode
jaymode approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lcawl
lcawl approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@exekias exekias mentioned this pull request Jul 10, 2018
Closed
26 tasks
dedemorton
dedemorton approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Jul 10, 2018

@dedemorton @lcawl Would one of you mind merging this PR into master? I don't have rights to do that on this repo.

Also, we don't yet want to backport this to 6.x; we'll do that once the rest of the Beats management feature is ready. I'm tracking this pending backport in the Beats management meta issue: elastic/beats#7028

@ycombinator ycombinator merged commit e2b14f7 into elastic:master Jul 10, 2018
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Jul 10, 2018

@dedemorton Please ignore my request in the previous comment. @lcawl set me up with the right permissions!

@ycombinator ycombinator mentioned this pull request Oct 4, 2018
Merged
@lcawl lcawl mentioned this pull request Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaymode jaymode jaymode approved these changes

@lcawl lcawl lcawl approved these changes

+1 more reviewer

@dedemorton dedemorton dedemorton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ycombinator @jaymode @dedemorton @lcawl