Skip to content

[DOCS] Adding stack_monitoring_agent role#127

Merged
lcawl merged 2 commits intoelastic:masterfrom
lcawl:lcawley-agent-role
Oct 25, 2018
Merged

[DOCS] Adding stack_monitoring_agent role#127
lcawl merged 2 commits intoelastic:masterfrom
lcawl:lcawley-agent-role

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Oct 10, 2018

@lcawl lcawl added the v7.0.0 label Oct 10, 2018
@lcawl lcawl requested a review from ycombinator October 10, 2018 16:06
@ycombinator
Copy link
Copy Markdown
Contributor

This LGTM but lets wait to merge this until after elastic/elasticsearch#34369 has been merged. Same dependency would apply to the backport PR as well.

@ycombinator
Copy link
Copy Markdown
Contributor

Hey @lcawl, elastic/elasticsearch#34369 still hasn't been merged but there are changes to the original proposal in that PR. Here is the new proposal for 2 built-in roles and 1 built-in user: elastic/elasticsearch#34369 (comment). Please let me know if you have any questions or need clarifications. Thanks.

Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lcawl lcawl merged commit 8a7063a into elastic:master Oct 25, 2018
@lcawl lcawl deleted the lcawley-agent-role branch October 25, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants